bit-badger/myPrayerJournal
1
0
Fork 0
Code Issues 1 Pull Requests Packages Projects Releases 36 Activity

tryJournalById returns entire request #42

New Issue
Closed
opened 2020-04-23 12:47:35 +00:00 by danieljsummers · 1 comment
danieljsummers commented 2020-04-23 12:47:35 +00:00 (Migrated from github.com)
Copy Link

The Data.tryJournalById function (called by Handlers.Request.get) is returning the entire request, including notes and history, which it should not be doing - that's what Data.tryFullRequestById (called by Handlers.Request.getFull) is for. Modify it to return the request with empty history and notes arrays.

(This was broken in the v2 conversion between EF Core and RavenDB.)

The `Data.tryJournalById` function (called by `Handlers.Request.get`) is returning the entire request, including notes and history, which it should not be doing - that's what `Data.tryFullRequestById` (called by `Handlers.Request.getFull`) is for. Modify it to return the request with empty history and notes arrays. _(This was broken in the v2 conversion between EF Core and RavenDB.)_
danieljsummers commented 2020-04-23 15:10:36 +00:00 (Migrated from github.com)
Copy Link

Fixed in v2.1.4

Fixed in v2.1.4
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
help wanted
infrastructure
Non-functionality related issues
invalid
question
security
Issue affects security
wontfix
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
danieljsummers
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bit-badger/myPrayerJournal#42
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?