tryJournalById returns entire request #42

New Issue

Closed

opened 2020-04-23 12:47:35 +00:00 by danieljsummers · 1 comment

danieljsummers commented 2020-04-23 12:47:35 +00:00 (Migrated from github.com)

Copy Link

Copy Source

The Data.tryJournalById function (called by Handlers.Request.get) is returning the entire request, including notes and history, which it should not be doing - that's what Data.tryFullRequestById (called by Handlers.Request.getFull) is for. Modify it to return the request with empty history and notes arrays.

(This was broken in the v2 conversion between EF Core and RavenDB.)

The `Data.tryJournalById` function (called by `Handlers.Request.get`) is returning the entire request, including notes and history, which it should not be doing - that's what `Data.tryFullRequestById` (called by `Handlers.Request.getFull`) is for. Modify it to return the request with empty history and notes arrays. _(This was broken in the v2 conversion between EF Core and RavenDB.)_

danieljsummers commented 2020-04-23 15:10:36 +00:00 (Migrated from github.com)

Copy Link

Copy Source

Fixed in v2.1.4

Fixed in v2.1.4

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

version4

php-pgsql

4.0.0-alpha1

3.4

3.3

3.2

3.1.1

3.1

3

2.2

2.1.4

2.1.3

2.1.2

2.1.1

2.1

2.0.1

2.0

1.2.2

1.2.1

1.2

1.1.1

1.1

1.0.1

1.0.0

0.9.8

0.9.7

0.9.6

0.9.5

0.9.3

0.9.2

0.9.1

0.9.0

0.8.5

0.8.4

0.8.3

0.8.2

0.8.1

0.8.0

Labels

Clear labels

bug

duplicate

enhancement

help wanted

infrastructure

Non-functionality related issues

invalid

question

security

Issue affects security

wontfix

No labels bug

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

danieljsummers (Daniel J. Summers)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bit-badger/myPrayerJournal#42