Requests Disappear when Prayed #26

New Issue

2019-09-02T04:13:19Z

danieljsummers commented

2019-09-02 04:13:19 +00:00

(Migrated from github.com)

On different devices, requests are disappearing rather than going to the bottom of the journal. I suspect this is due to time differences between the device and the server. Modify the web app to send the timestamp along with actions such as "Prayed" or "Updated", and use that instead of taking the value of "now" from the server.

danieljsummers commented

2019-09-02 04:13:48 +00:00

(Migrated from github.com)

this will be part of v2

danieljsummers commented

2019-09-02 12:45:53 +00:00

(Migrated from github.com)

The more I thought about this, taking the client's incorrect time is the wrong solution. Rather than using the time from the client, zero out showAfter server-side instead for immediately recurring requests. This will move them to the bottom of the journal (sorted by asOf desc) and will not trigger the issues that setting it to the current date/time does. Non-immediate recurrence requests should disappear until their recurrence time comes back around, and still will, because their showAfter will be computed based on their recurrence.

The more I thought about this, taking the client's incorrect time is the wrong solution. Rather than using the time from the client, zero out `showAfter` server-side instead for immediately recurring requests. This will move them to the bottom of the journal (sorted by `asOf` desc) and will not trigger the issues that setting it to the current date/time does. Non-immediate recurrence requests should disappear until their recurrence time comes back around, and still will, because their `showAfter` will be computed based on their recurrence.

danieljsummers commented

2019-09-03 00:04:52 +00:00

(Migrated from github.com)

Fixed in v2

Sign in to join this conversation.