bit-badger/myWebLog
1
0
Fork 0
Code Issues 4 Pull Requests Packages Projects Releases 11 Activity

Support start/end dashes in include_template tag #26

New Issue
Closed
opened 2022-07-26 15:04:14 +00:00 by danieljsummers · 1 comment
danieljsummers commented 2022-07-26 15:04:14 +00:00 (Migrated from github.com)
Copy Link

The Liquid templating language specifies that, if a tag starts with {%- or ends with -%}, if there is a line break immediately before or after that tag, it will not be preserved. Currently, the custom include_template tag does not support this, as it's implemented as a regular expression that is replaced when the template is initially read.

Modify the processing for this tag to support the no-new-line options the way other Liquid tags do.

The Liquid templating language specifies that, if a tag starts with `{%-` or ends with `-%}`, if there is a line break immediately before or after that tag, it will not be preserved. Currently, the custom `include_template` tag does not support this, as it's implemented as a regular expression that is replaced when the template is initially read. Modify the processing for this tag to support the no-new-line options the way other Liquid tags do.
danieljsummers added the
wontfix
 label 2024-08-25 00:50:43 +00:00
danieljsummers commented 2024-08-25 00:50:50 +00:00
Copy Link

With the change from Liquid to Fluid (#47), include will be supported, so the custom include tag will no longer be needed.

With the change from Liquid to Fluid (#47), `include` will be supported, so the custom include tag will no longer be needed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area
infrastructure
Issues related to supported frameworks and libraries
area
podcasting
Issues related to podcasting / episodes
area
setup
Issues related to installation and setup
area
theming
Issues related to templates and theme
area
writing
Issues related to pages and posts
bug
annoyance
An issue that should be fixed, but is not a show-stopper
bug
footgun
Prevent preventable errors
bug
moderate
An issue that should be fixed with the next release
bug
urgent
A show-stopping bug; fix urgently
duplicate
enhancement
deprecation
Replace deprecated libraries with newer ones
enhancement
feature
A new feature to be added
help wanted
invalid
question
wontfix
No Label
enhancement
feature
wontfix
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
danieljsummers
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bit-badger/myWebLog#26
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?