bit-badger/BitBadger.Documents
1
0
Fork 0
Code Issues Pull Requests Projects Releases 11 Activity

Make Field constructor functions generic #8

Merged
danieljsummers merged 2 commits from v-four-rc5 into main 2024-09-18 13:36:15 +00:00
Conversation 0 Commits 2 Files Changed 3 +39 -24
danieljsummers commented 2024-09-18 13:35:55 +00:00
Owner
Copy Link

F# can upcast types to obj if those types are used in place. However, a string seq (IEnumerable<string> in C#) cannot be upcast to an obj seq (IEnumerable<object>) without mapping each item in the sequence. Making the Field constructor functions generic will allow them to take any object type, and these functions handle the conversion to obj (for In and InArray; others work transparently).

F# can upcast types to `obj` if those types are used in place. However, a `string seq` (`IEnumerable<string>` in C#) cannot be upcast to an `obj seq` (`IEnumerable<object>`) without mapping each item in the sequence. Making the `Field` constructor functions generic will allow them to take any object type, and these functions handle the conversion to `obj` (for `In` and `InArray`; others work transparently).
danieljsummers added 2 commits 2024-09-18 13:35:56 +00:00 
Probably only needed for In/InArray, but implemented for all
danieljsummers self-assigned this 2024-09-18 13:36:02 +00:00
danieljsummers merged commit 740767661c into main 2024-09-18 13:36:15 +00:00
danieljsummers deleted branch v-four-rc5 2024-09-18 13:36:15 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
infrastructure
Keep the library and its dependencies current
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
danieljsummers
No Assignees danieljsummers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bit-badger/BitBadger.Documents#8
No description provided.
Delete Branch "v-four-rc5"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?